Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✅ Testでgo-cmpを使うように #829

Merged
merged 11 commits into from
Dec 30, 2024
Merged

✅ Testでgo-cmpを使うように #829

merged 11 commits into from
Dec 30, 2024

Conversation

H1rono
Copy link
Member

@H1rono H1rono commented Dec 28, 2024

#828 #823
ここでcloseしたい

Copy link

codecov bot commented Dec 28, 2024

Codecov Report

Attention: Patch coverage is 68.18182% with 7 lines in your changes missing coverage. Please review.

Project coverage is 25.29%. Comparing base (27d5da6) to head (a49569a).
Report is 12 commits behind head on v2.

Files with missing lines Patch % Lines
testutil/cmp.go 65.00% 6 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               v2     #829      +/-   ##
==========================================
- Coverage   25.29%   25.29%   -0.01%     
==========================================
  Files         147      148       +1     
  Lines       30803    30823      +20     
==========================================
+ Hits         7793     7798       +5     
- Misses      22122    22135      +13     
- Partials      888      890       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Fixed `admin_test.go`, `file_test.go`, `group_test.go`
@H1rono H1rono force-pushed the test-cmp branch 2 times, most recently from ca10173 to ff25a42 Compare December 29, 2024 16:31
@H1rono
Copy link
Member Author

H1rono commented Dec 30, 2024

長い戦いだった...
マージ

@H1rono H1rono merged commit a637f70 into v2 Dec 30, 2024
7 checks passed
@H1rono H1rono deleted the test-cmp branch December 30, 2024 15:34
@H1rono
Copy link
Member Author

H1rono commented Dec 30, 2024

あcloseし忘れてる

@H1rono H1rono mentioned this pull request Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant